Add GPU tracking to Jobs realm #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpalmer
added
Category:ETL
6 tasks
jpwhite4
reviewed
Mar 20, 2020
| $console = Console::factory(); | ||
| $console->displayMessage(<<<"EOT" | ||
| This version of Open XDMoD has support for GPU metrics in the jobs realm. If | ||
| you have shredded Slurm job records in the past it is possible to extract the |
There was a problem hiding this comment.
What version of XDMoD was the reqgres data added? Or has the capability been there effectively forever?
There was a problem hiding this comment.
It was added in 6.5 (released 2017-01-10).
There was a problem hiding this comment.
Perhaps just a note in the markdown docs about this. I doubt many people have pre 6.5 data in their database.
There was a problem hiding this comment.
I added a note to the upgrade documentation.
jpwhite4
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds GPU statistics and a group by to the jobs realm. Only includes support for Slurm at this time.
Replaces #1235
Motivation and Context
https://app.asana.com/0/15230011293693/1145503330514643
Tests performed
Added additional tests and regression test data.
Types of changes
Checklist: